[Backport 2.x] Add tracing instrumentation for indexing paths #10962

rayshrey · 2023-10-27T11:43:40Z

Description

Auto-backport for this PR failed.
Manually raising a PR to backport changes to 2.x

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
Commits are signed per the DCO using --signoff
Commit changes are listed out in CHANGELOG.md file (See: Changelog)
Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

) * Add tracing instrumentation for indexing paths Signed-off-by: Shreyansh Ray <[email protected]> * Fix failing tests and review changes Signed-off-by: Shreyansh Ray <[email protected]> * Fix test failures due to Span not being properly closed Signed-off-by: Shreyansh Ray <[email protected]> * Changes to spans in primary and replica actions Signed-off-by: Shreyansh Ray <[email protected]> * Review comments fixes and refactoring Signed-off-by: Shreyansh Ray <[email protected]> * Precommit auto-changes Signed-off-by: Shreyansh Ray <[email protected]> * Add refresh policy as attribute Signed-off-by: Shreyansh Ray <[email protected]> * Fix changelog entry Signed-off-by: Shreyansh Ray <[email protected]> * Instrument primary/replica write in TransportWriteAction instead of TransportShardBulkAction Signed-off-by: Shreyansh Ray <[email protected]> * Modify SpanBuilder Signed-off-by: Shreyansh Ray <[email protected]> * spotlessApply and precommit Signed-off-by: Shreyansh Ray <[email protected]> * Change span names Signed-off-by: Shreyansh Ray <[email protected]> * Pass Noop Tracer instead of injected tracer Signed-off-by: Shreyansh Ray <[email protected]> * Reverting previous changes Signed-off-by: Shreyansh Ray <[email protected]> * Remove tracer variable from TransportShardBulkAction Signed-off-by: Shreyansh Ray <[email protected]> --------- Signed-off-by: Shreyansh Ray <[email protected]>

github-actions · 2023-10-27T12:23:17Z

Compatibility status:

Checks if related components are compatible with change 8339e14

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/reporting.git]

github-actions · 2023-10-27T12:28:11Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/29138/
CommitID: 8339e14
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

reta · 2023-10-27T13:00:58Z

URL: https://build.ci.opensearch.org/job/gradle-check/29138/

#5957
#10755
#10798

github-actions · 2023-10-27T13:32:38Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/29144/
CommitID: 8339e14
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

reta · 2023-10-27T13:45:01Z

URL: https://build.ci.opensearch.org/job/gradle-check/29144/

#8771

github-actions · 2023-10-27T14:13:40Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/29148/
CommitID: 8339e14
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

reta · 2023-10-27T14:57:31Z

URL: https://build.ci.opensearch.org/job/gradle-check/29148/

#10969

github-actions · 2023-10-27T15:44:50Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/29154/
CommitID: 8339e14
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

reta · 2023-10-27T15:52:03Z

URL: https://build.ci.opensearch.org/job/gradle-check/29148/

#10231

github-actions · 2023-10-27T16:40:35Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/29158/
CommitID: 8339e14
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

reta · 2023-10-27T17:06:44Z

URL: https://build.ci.opensearch.org/job/gradle-check/29158/

#9499
#10902

github-actions · 2023-10-27T17:58:09Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❕
TEST FAILURES:

      1 org.opensearch.remotestore.RemoteStoreStatsIT.testDownloadStatsCorrectnessSinglePrimaryMultipleReplicaShards

URL: https://build.ci.opensearch.org/job/gradle-check/29162/
CommitID: 8339e14
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

codecov · 2023-10-27T17:58:11Z

We're currently processing your upload. This comment will be updated when the results are available.

reta approved these changes Oct 27, 2023

View reviewed changes

reta added backport PRs or issues specific to backporting features or enhancments v2.12.0 Issues and PRs related to version 2.12.0 labels Oct 27, 2023

reta merged commit d179a0a into opensearch-project:2.x Oct 27, 2023
68 checks passed

rayshrey deleted the 2.x branch November 2, 2023 09:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Backport 2.x] Add tracing instrumentation for indexing paths #10962

[Backport 2.x] Add tracing instrumentation for indexing paths #10962

rayshrey commented Oct 27, 2023

github-actions bot commented Oct 27, 2023

github-actions bot commented Oct 27, 2023

reta commented Oct 27, 2023

github-actions bot commented Oct 27, 2023

reta commented Oct 27, 2023

github-actions bot commented Oct 27, 2023

reta commented Oct 27, 2023

github-actions bot commented Oct 27, 2023

reta commented Oct 27, 2023

github-actions bot commented Oct 27, 2023

reta commented Oct 27, 2023 •

edited

Loading

github-actions bot commented Oct 27, 2023

codecov bot commented Oct 27, 2023

[Backport 2.x] Add tracing instrumentation for indexing paths #10962

[Backport 2.x] Add tracing instrumentation for indexing paths #10962

Conversation

rayshrey commented Oct 27, 2023

Description

Related Issues

Check List

github-actions bot commented Oct 27, 2023

Compatibility status:

Incompatible components

Skipped components

Compatible components

github-actions bot commented Oct 27, 2023

Gradle Check (Jenkins) Run Completed with:

reta commented Oct 27, 2023

github-actions bot commented Oct 27, 2023

Gradle Check (Jenkins) Run Completed with:

reta commented Oct 27, 2023

github-actions bot commented Oct 27, 2023

Gradle Check (Jenkins) Run Completed with:

reta commented Oct 27, 2023

github-actions bot commented Oct 27, 2023

Gradle Check (Jenkins) Run Completed with:

reta commented Oct 27, 2023

github-actions bot commented Oct 27, 2023

Gradle Check (Jenkins) Run Completed with:

reta commented Oct 27, 2023 • edited Loading

github-actions bot commented Oct 27, 2023

Gradle Check (Jenkins) Run Completed with:

codecov bot commented Oct 27, 2023

reta commented Oct 27, 2023 •

edited

Loading